Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base branch for new talktorials #74

Merged
merged 329 commits into from
Sep 9, 2021
Merged

Base branch for new talktorials #74

merged 329 commits into from
Sep 9, 2021

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 25, 2020

Description

This is the base PR for the next round of new talktorials.
Some notebooks involve refactoring and extension of the former T11 talktorial series.
Supersedes #69 originally opened by @dominiquesydow.

TODOs

Questions

Status

  • Ready to go

@jaimergp jaimergp mentioned this pull request Nov 25, 2020
15 tasks
@dominiquesydow dominiquesydow changed the title Base branch for T11 revamp Base branch for new talktorials Dec 11, 2020
@dominiquesydow dominiquesydow added the enhancement New feature or request label Dec 11, 2020
@dominiquesydow
Copy link
Collaborator

@schallerdavid could you please take a look at the CI fail for T016 concerning plip, potentially propagating from the MDAnalysis 3.0.0 update:
https://github.com/volkamerlab/teachopencadd/runs/3481452711#step:8:270

The chain IDs are apparently set to X (instead of A). Have you encountered this already in your plipify project?

@schallerdavid
Copy link
Collaborator

@schallerdavid could you please take a look at the CI fail for T016 concerning plip, potentially propagating from the MDAnalysis 3.0.0 update:
https://github.com/volkamerlab/teachopencadd/runs/3481452711#step:8:270

The chain IDs are apparently set to X (instead of A). Have you encountered this already in your plipify project?

You are correct, it's all about the chain name being changed to "X". We did not touch plipify for quite a while, so I am not sure how this change affects this project. Anyway, OpenCADD is retrieving the PDB entry in MMTF format. In the MDAnalysis docs they list all read attributes, chain ID, and element information are not read. I rerun the notebook and pushed the updated version. Let's hope the tests pass.

@dominiquesydow dominiquesydow linked an issue Sep 8, 2021 that may be closed by this pull request
@dominiquesydow dominiquesydow linked an issue Sep 8, 2021 that may be closed by this pull request
@dominiquesydow dominiquesydow self-assigned this Sep 8, 2021
@dominiquesydow dominiquesydow linked an issue Sep 8, 2021 that may be closed by this pull request
@dominiquesydow dominiquesydow added the new talktorial New talktorial label Sep 8, 2021
@dominiquesydow
Copy link
Collaborator

We have passing tests incl. Windows! Fails for Ubuntu are only connection timeouts! 🥳
I will merge this PR now :)

We can deal with conda packaging, website polishing ect. (see #137) in new and more digestible PRs.

A big THANK YOU to everyone who contributed new talktorials in this PR!
Also thanks to @schallerdavid for helping me out to fix the CI problems!

@dominiquesydow dominiquesydow merged commit 892f4f5 into master Sep 9, 2021
@dominiquesydow dominiquesydow deleted the t011-base branch September 9, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment