-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace deprecation ioutil
fucntions and add depguard rules in .golangci.yml
#3808
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: dongjiang1989 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @hwdef Please re-check it |
Please fix the CI |
Hmmm....🤔️ Maybe main branch CI pipeline fail ... ref: |
Please rebase the new master branch because CI has been fixed: #3817 |
Great! @JesseStutler . thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/assign @hwdef |
@lowang-bh @Monokaix Please take a look |
New changes are detected. LGTM label has been removed. |
io/ioutil
functions.ioutil.ReadFile
->os.ReadFile
ref: https://pkg.go.dev/io/ioutil
Add depguard rules in
.golangci.yml
fix golangci-lint warning