Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multiple REMOTE_ISF_URLs #1416

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

TheMythologist
Copy link
Contributor

Also removes duplicates of word "the"

Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you provide a rationale for why having multiple remote ISF urls would be useful? My concern is the order of application, which I can see you've reversed to prioritize the first one. This then also requires any users that have specified it in their default options to change their configurations (and know that the first one in the list takes precedence, which might be confusing to people). I'd just like to talk/think this through a bit more before going ahead with it please...

@TheMythologist
Copy link
Contributor Author

My rationale for this was that we could provide multiple ISF URLs to reference, especially if you're using online ones that are curated by the community (not by yourself). I could also edit the code to be backwards compatible if that is your concern. Alternatively, if you don't see the need for this feature, feel free to close this PR entirely 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants