Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag --nofile to prevent a file from being written in the ConfigWriter plugin #1356

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JSCU-CNI
Copy link

@JSCU-CNI JSCU-CNI commented Nov 18, 2024

The configwriter plugin automatically writes configuration files (duh!) to disk. If one just needs the output of the configwriter plugin, a file is automatically written. Hence we added the flag --nofile to prevent the configuration file from being written.

A better approach would have been to not have the configwriter plugin write a file by default and have a -o flag determine where the file would be written to. This is not backwards compatible, and has hence not been added. If you would like us to do that instead, we'd be glad to.

N.B.: this is our first PR! Glad to be part of the Volatility community. Feel free to give us (extensive) feedback on the contributions we make :)

@JSCU-CNI JSCU-CNI changed the title Add configwriter flag Add flag --nofile to prevent a file from being written in the ConfigWriter plugin Nov 18, 2024
@ikelos
Copy link
Member

ikelos commented Nov 18, 2024

Thanks very much for your contribution. It feels like it would be more consistent to change it to a --dump option, to be in keeping with the rest of the plugins? Since that would be a major shift in how the plugin works, it would be best to also bump the major version number or possibly rename the plugin to just imageconfig or something? Then it could output the text as provided and if given the --dump configuration it could output the file as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants