Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build package for umbraco 9 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lynnewritescode
Copy link

No description provided.

@greystate
Copy link
Member

Hey @lynnewritescode - thanks a bunch for this 👍

I need to take a longer look at this as I've not yet ventured into any nuget stuff for any of our packages.

@lynnewritescode
Copy link
Author

Hey @lynnewritescode - thanks a bunch for this 👍

I need to take a longer look at this as I've not yet ventured into any nuget stuff for any of our packages.

Hey! No worries, I found your package recently and might need to use it in an umbraco 9 project, so thought I’d give it a go. Hopefully this helps!

@csurfleet
Copy link

Is there anything I can do to move this forward? I really need to use this package in v9 and will happily help out if anything needs doing

@greystate
Copy link
Member

@csurfleet I am pretty sure you should be able to take Lynne's code from this PR and use it as is.

Sadly I'm not able to just merge it into the main branch, since I'd loose all of my own build scripts etc. - which is just me wanting to be able to do fixes etc. for all versions.

I do want to be able to provide a nuget package at some point, but I have no timeframe for that yet.

@greystate
Copy link
Member

Hey @lynnewritescode & @csurfleet

FYI, there is now an official NuGet package for this:

NuGet: https://nuget.org/packages/Vokseverk.ImageHotspot

Umbraco Marketplace: https://marketplace.umbraco.com/package/vokseverk.imagehotspot

I am not closing this PR yet, because the NuGet package is for Umbraco 10+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants