Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kiwix-lib-10.0.1 kiwix-tools-3.2.0 libzim-7.2.0 zim-tools-3.1.0 #35607

Closed
wants to merge 5 commits into from
Closed

Update kiwix-lib-10.0.1 kiwix-tools-3.2.0 libzim-7.2.0 zim-tools-3.1.0 #35607

wants to merge 5 commits into from

Conversation

Animeshz
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@Johnnynator
Copy link
Member

Looks good.
It would be nice if you could fix the tests. (you can pass -Q to ./xbps-src to run them locally). E.g. libzim misses the files from the zim-testing-suite. Check: https://github.com/openzim/libzim/blob/master/scripts/download_test_data.py so https://github.com/openzim/zim-testing-suite/releases/download/v0.3/zim-testing-suite-0.3.tar.gz is needed as additional distfile.

@Animeshz Animeshz force-pushed the kiwix branch 3 times, most recently from d6d2c52 to 8ea2239 Compare February 15, 2022 09:54
@Animeshz
Copy link
Contributor Author

Animeshz commented Feb 15, 2022 •
edited
Loading

Dunno why that last test (reader.cpp) go into deadlock have made an upstream issue there.

@Animeshz Animeshz force-pushed the kiwix branch 2 times, most recently from 754a265 to 546530c Compare February 16, 2022 05:32
@paper42
Copy link
Member

paper42 commented Mar 5, 2022

remove libzim-musl-logs.txt, I think you added it by accident

@Animeshz
Copy link
Contributor Author

Animeshz commented Mar 5, 2022

Yeah sorry, I've noticed, but this isn't really merge-able till openzim/libzim#671 (musl-bug) I guess, I'll remove when its fixed along with a version bump or a patch.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 24, 2022
@github-actions github-actions bot closed this Jul 9, 2022
@Animeshz Animeshz deleted the kiwix branch March 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Animeshz @Johnnynator @paper42