-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inputs figma #857
base: develop
Are you sure you want to change the base?
Inputs figma #857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Uploader" is a single word (so it should be UploaderCustom.tsx
.
Edit: Actually, why call it Custom
??? There's no need at all, this is the only component that would be named Uploader in the entire project, if I'm not wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will investigate since it doesn't recognize the changes from uppercase to lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried using the terminal..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, you're styling everything using basestyles, but colors should be defined using colorSchemes and sizes (paddings, margins, gaps, border radius...) using sizes
applied Inputs, checkboxes, radio, dropdowns, uploader (custom component to manage states) and text area figma styles
closes #848