Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs figma #857

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Inputs figma #857

wants to merge 5 commits into from

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Nov 28, 2024

applied Inputs, checkboxes, radio, dropdowns, uploader (custom component to manage states) and text area figma styles

closes #848

Copy link

github-actions bot commented Nov 28, 2024

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 11:10 Inactive
Copy link

github-actions bot commented Nov 28, 2024

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 11:11 Inactive
src/components/Editor/Editor.tsx Outdated Show resolved Hide resolved
src/components/Editor/Editor.tsx Outdated Show resolved Hide resolved
src/components/Editor/Editor.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Uploader" is a single word (so it should be UploaderCustom.tsx.

Edit: Actually, why call it Custom??? There's no need at all, this is the only component that would be named Uploader in the entire project, if I'm not wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will investigate since it doesn't recognize the changes from uppercase to lowercase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried using the terminal..?

src/components/Editor/Editor.tsx Outdated Show resolved Hide resolved
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, you're styling everything using basestyles, but colors should be defined using colorSchemes and sizes (paddings, margins, gaps, border radius...) using sizes

src/theme/components/checkbox.ts Outdated Show resolved Hide resolved
src/theme/components/checkbox.ts Outdated Show resolved Hide resolved
src/theme/components/checkbox.ts Show resolved Hide resolved
src/theme/components/checkbox.ts Show resolved Hide resolved
src/theme/components/checkbox.ts Show resolved Hide resolved
src/theme/components/input.ts Outdated Show resolved Hide resolved
src/theme/components/input.ts Outdated Show resolved Hide resolved
src/theme/components/input.ts Show resolved Hide resolved
src/theme/components/input.ts Show resolved Hide resolved
src/theme/components/input.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 11:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 11:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style Forms
2 participants