Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vic appliance ip information in vic plugin summary view. #598

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

zhoumeina
Copy link
Contributor

@zhoumeina zhoumeina commented Sep 12, 2018

As the user is not able to select which API server to use (#572), providing this information may greatly aid debugging when multiple versions of API servers are available.
Fix:
1 Add vic appliance version information in summary view.
2 Add vic appliance ip address in summary view.

@zhoumeina
Copy link
Contributor Author

image

@@ -96,6 +97,7 @@ export class VicSummaryViewComponent implements OnInit, OnDestroy {
this.createWzService.verifyVicMachineApiEndpoint()
.subscribe(
(ip: string) => {
this.applianceIp = ip;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we only set the IP if an error does not occur. Given the goal of aiding a user in debugging, it seems like we would also want to set the IP in that case too.

@javierfz1980
Copy link
Contributor

There are some comments,

Also please provide the acceptance criteria checklist:


Fixes #572 (the number of the issue this PR is fixing/adding)

PR acceptance checklist:

[ ] All unit tests pass
[ ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*

*if applicable, add n/a if not


@renmaosheng
Copy link
Contributor

please update the commit message as well, given that ova version is also added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants