-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vic appliance ip information in vic plugin summary view. #598
Conversation
e57cc12
to
456d47f
Compare
456d47f
to
0b638d5
Compare
@@ -96,6 +97,7 @@ export class VicSummaryViewComponent implements OnInit, OnDestroy { | |||
this.createWzService.verifyVicMachineApiEndpoint() | |||
.subscribe( | |||
(ip: string) => { | |||
this.applianceIp = ip; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we only set the IP if an error does not occur. Given the goal of aiding a user in debugging, it seems like we would also want to set the IP in that case too.
There are some comments, Also please provide the Fixes #572 (the number of the issue this PR is fixing/adding) PR acceptance checklist: [ ] All unit tests pass *if applicable, add n/a if not |
0b638d5
to
0212878
Compare
Signed-off-by: Meina Zhou <[email protected]>
0212878
to
db1247f
Compare
please update the commit message as well, given that ova version is also added. |
As the user is not able to select which API server to use (#572), providing this information may greatly aid debugging when multiple versions of API servers are available.
Fix:
1 Add vic appliance version information in summary view.
2 Add vic appliance ip address in summary view.