-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD fixes #506
Merged
Merged
CI/CD fixes #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshedi
force-pushed
the
dockerfile-fixes
branch
4 times, most recently
from
December 2, 2024 08:18
1593be0
to
5a4fde3
Compare
sshedi
force-pushed
the
dockerfile-fixes
branch
4 times, most recently
from
December 2, 2024 12:23
8ee693a
to
763bddf
Compare
oliverkurth
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! It looks mostly good to me, but I have a few comments.
I always dislikes the _topdir
in the spec files, but never had the energy to fix it. Thanks!
sshedi
force-pushed
the
dockerfile-fixes
branch
2 times, most recently
from
December 3, 2024 08:36
ac8c3b3
to
82f0d10
Compare
oliverkurth
reviewed
Dec 3, 2024
sshedi
force-pushed
the
dockerfile-fixes
branch
from
December 4, 2024 04:20
82f0d10
to
0f3aaf6
Compare
Signed-off-by: Shreenidhi Shedi <[email protected]>
Signed-off-by: Shreenidhi Shedi <[email protected]>
Signed-off-by: Shreenidhi Shedi <[email protected]>
No need to use %_topdir in specs, it is implicitly done setup-repo.sh: No need to pass `-r' to rpmbuild command, it was a wrong usage for our usecase Signed-off-by: Shreenidhi Shedi <[email protected]>
skipping cache dir out of space checks Fix small cache test Signed-off-by: Shreenidhi Shedi <[email protected]>
sshedi
force-pushed
the
dockerfile-fixes
branch
from
December 7, 2024 21:33
0f3aaf6
to
d7c743a
Compare
sshedi
pushed a commit
to sshedi/tdnf
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this work with an idea to segregate package list in docker files but found some other issues along the way.
default
Key-Curve for generating gpg keys (throws unknown elliptic curve error), so switched to RSA