Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD fixes #506

Merged
merged 5 commits into from
Dec 11, 2024
Merged

CI/CD fixes #506

merged 5 commits into from
Dec 11, 2024

Conversation

sshedi
Copy link
Contributor

@sshedi sshedi commented Dec 2, 2024

I started this work with an idea to segregate package list in docker files but found some other issues along the way.

  • We were using Fedora-34 for testing, so switched to using latest (F41)
  • When I switched to F41, lot of spec issues popped up and all were correct.
  • Ended up fixing many spec files in test repo
  • No need to pass both rootdir option and topdir option to rpmbuild, unless we are doing something in chroot and this caused regressions in F41 while build rpms from specs
  • F41 is not happy with default Key-Curve for generating gpg keys (throws unknown elliptic curve error), so switched to RSA

@sshedi sshedi force-pushed the dockerfile-fixes branch 4 times, most recently from 1593be0 to 5a4fde3 Compare December 2, 2024 08:18
@sshedi sshedi changed the title Dockerfile fixes CI/CD fixes Dec 2, 2024
@sshedi sshedi force-pushed the dockerfile-fixes branch 4 times, most recently from 8ee693a to 763bddf Compare December 2, 2024 12:23
Copy link
Contributor

@oliverkurth oliverkurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! It looks mostly good to me, but I have a few comments.

I always dislikes the _topdir in the spec files, but never had the energy to fix it. Thanks!

ci/docker-entrypoint.sh Outdated Show resolved Hide resolved
pytests/tests/test_cache.py Outdated Show resolved Hide resolved
pytests/tests/test_cache.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
ci/Dockerfile.fedora Show resolved Hide resolved
@sshedi sshedi force-pushed the dockerfile-fixes branch 2 times, most recently from ac8c3b3 to 82f0d10 Compare December 3, 2024 08:36
ci/prep.sh Outdated Show resolved Hide resolved
Signed-off-by: Shreenidhi Shedi <[email protected]>
No need to use %_topdir in specs, it is implicitly done

setup-repo.sh: No need to pass `-r' to rpmbuild command, it was a wrong
usage for our usecase

Signed-off-by: Shreenidhi Shedi <[email protected]>
skipping cache dir out of space checks

Fix small cache test

Signed-off-by: Shreenidhi Shedi <[email protected]>
@oliverkurth oliverkurth merged commit 56681b2 into vmware:dev Dec 11, 2024
4 checks passed
@sshedi sshedi deleted the dockerfile-fixes branch December 11, 2024 04:19
sshedi pushed a commit to sshedi/tdnf that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants