Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to manage plugin owned settings #99

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Sep 20, 2023

What this PR does / why we need it

  • Provide an API to manage plugin owned settings

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • Added unit tests

Manually testing

  • Triggered the new API in a test plugin to retrieve the plugins dir

**Test plugin with plugins command**

var pluginsCmd = &cobra.Command{
	Use:   "plugin",
	Short: "Plugin tests",
	Run: func(cmd *cobra.Command, args []string) {
		pluginsDir, err := configlib.GetTanzuPluginConfigDir()
		if err != nil {
			log.Fatal(err, "")
		}
		log.Info(pluginsDir)
	},
}

mpanchajanya@mpanchajanF09MK ~ % tanzu test plugin
[i] /Users/mpanchajanya/.config/tanzu/plugins
mpanchajanya@mpanchajanF09MK ~ %

Release note

Add new API to return config directory to manage plugin owned settings

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya self-assigned this Sep 20, 2023
@mpanchajanya mpanchajanya marked this pull request as ready for review September 22, 2023 14:52
@mpanchajanya mpanchajanya requested a review from a team as a code owner September 22, 2023 14:52
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@mpanchajanya mpanchajanya merged commit 923c4c1 into vmware-tanzu:main Sep 27, 2023
4 checks passed
@marckhouzam marckhouzam added this to the v1.1.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants