Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help text template to fix target usage (#94) #95

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Sep 15, 2023

  • Update help text template to fix target usage

  • Add two spaces for tanzu command

  • Convert the help template to go code

Signed-off-by: Marc Khouzam [email protected]

  • testing the lint and tests

  • refactor the print help

  • refactor the indentation

  • Update check to HasPrefix from HasSuffix

  • Update tests to include global flags and fetch --help command

  • Update additional help topics section with tanzu and target prefix

  • Revert additional help topics targeted prefix

  • Deprecate CmdTemplate and introduce private cmdTemplate variable and update all usages

  • Fix sub command unit tests by executing plugin instead of command

  • Fix spacing in examples section and update tests


Signed-off-by: Marc Khouzam [email protected]
Co-authored-by: Marc Khouzam [email protected]
(cherry picked from commit 3923e33)

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Deprecate CmdTemplate and Update help text template go function to specify plugin target

Additional information

Special notes for your reviewer

* Update help text template to fix target usage

* Add two spaces for tanzu command

* Convert the help template to go code

Signed-off-by: Marc Khouzam <[email protected]>

* testing the lint and tests

* refactor the print help

* refactor the indentation

* Update check to HasPrefix from HasSuffix

* Update tests to include global flags and fetch --help command

* Update additional help topics section with tanzu and target prefix

* Revert additional help topics targeted prefix

* Deprecate CmdTemplate and introduce private cmdTemplate variable and update all usages

* Fix sub command unit tests by executing plugin instead of command

* Fix spacing in examples section and update tests

---------

Signed-off-by: Marc Khouzam <[email protected]>
Co-authored-by: Marc Khouzam <[email protected]>
(cherry picked from commit 3923e33)
@mpanchajanya mpanchajanya self-assigned this Sep 15, 2023
@mpanchajanya mpanchajanya marked this pull request as ready for review September 15, 2023 17:46
@mpanchajanya mpanchajanya requested a review from a team as a code owner September 15, 2023 17:46
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@mpanchajanya mpanchajanya merged commit 51a4739 into vmware-tanzu:release-1.0 Sep 15, 2023
1 check passed
@marckhouzam marckhouzam added this to the v1.0.2 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants