Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt opts to SelectConfig.Run #208

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

gabbigum
Copy link
Contributor

What this PR does / why we need it

When we use SelectConfig.Run(..) we should be able to pass PrompOpt.. as argument similar to PromptConfig. When we're not able to do this interactive testing for MultiSelect becomes impossible.

Which issue(s) this PR fixes

Fixes #207

Release note

Add PrompOpt parameter to SelectConfig.Run() method. This allows SelectConfig to have behaviour similar to PromptConfig

Special notes for your reviewer

The issue is tracked down also in VMware Jira: TANZU-9559

@gabbigum gabbigum requested a review from a team as a code owner August 26, 2024 11:03
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix 👍

@gabbigum
Copy link
Contributor Author

Great @anujc25! Can we merge the fix so it's available with next release?

@anujc25
Copy link
Contributor

anujc25 commented Aug 27, 2024

Great @anujc25! Can we merge the fix so it's available with next release?

Yes. I will merge it today.

@anujc25 anujc25 merged commit e7a4e03 into vmware-tanzu:main Aug 27, 2024
5 checks passed
@anujc25 anujc25 added this to the v1.5.0 milestone Aug 27, 2024
anujc25 pushed a commit to anujc25/tanzu-plugin-runtime that referenced this pull request Aug 30, 2024
anujc25 pushed a commit that referenced this pull request Aug 30, 2024
@marckhouzam marckhouzam modified the milestones: v1.5.0, v1.4.3 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select component does not propagate PromptOpts to survey
4 participants