Fix the missing "interactiveMode" field in kubeconfig generated by GetKubeconfigForContext() API #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tKubeconfigForContext() API Signed-off-by: Prem Kumar Kalle <[email protected]>
Signed-off-by: Prem Kumar Kalle <[email protected]>
prkalle
force-pushed
the
fix/kubeconfig_interactiveMode
branch
from
f3cc4ba
to
7f9898f
Compare
vuil
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR fixes the missing "interactiveMode" field in the kubeconfig(in user.exec structure) generated by GetKubeconfigForContext() API
Changes Summary:
AuthInfostructure intae/internal/kubconfig/types.goto empty interface to address the loss of information during yaml marshaling because GetKubeconfigForContext() would not modify the AuthInfo structure of Kubeconfig.Which issue(s) this PR fixes
Fixes #109
Describe testing done for PR
Unit tests updated to have
interactiveModefield and validated the kubeconfig generated by GetKubeconfigForContext() API hasinteractiveModefield.Release note
Additional information
Special notes for your reviewer