Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golangci-lint version #104

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Fix golangci-lint version #104

merged 3 commits into from
Sep 29, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Sep 29, 2023 •
edited
Loading

What this PR does / why we need it

  • Update golangci-lint version to 1.51.0 which is supported by go 1.18
  • Update the workflow lint to go 1.18 and update lint cache key
  • Disable deprecated linters

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

make lint - pass on local

Release note

Update golangci-lint to supported go 1.18 and disable deprecated linters

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya changed the title testing lint Fix golangci-lint version Sep 29, 2023
vuil
vuil reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if previous changes have messed up the cache, instead of removing it I recommend using a different key e.g. ...lint-cache-3

@vuil
Copy link
Contributor

vuil commented Sep 29, 2023

Also since we are fixing linters, can you also remove the deprecated linters like in
#105?

@mpanchajanya mpanchajanya marked this pull request as ready for review September 29, 2023 19:47
@mpanchajanya mpanchajanya requested a review from a team as a code owner September 29, 2023 19:47
vuil
vuil approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks.

@vuil vuil merged commit 301f057 into vmware-tanzu:main Sep 29, 2023
4 checks passed
@marckhouzam marckhouzam added this to the v1.1.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuil vuil vuil approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mpanchajanya @vuil @marckhouzam @vmwclabot