Add API to get the Kubeconfig for an arbitrary UCP resource #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prkalle
force-pushed
the
add/get_ucp_kubeconfig
branch
from
ab49add
to
1e5cd8f
Compare
|
Also Could you add more details on PR description regarding the changes and new APIs. Thanks |
prkalle
force-pushed
the
add/get_ucp_kubeconfig
branch
from
1e5cd8f
to
7613c76
Compare
mpanchajanya
approved these changes
Sep 27, 2023
anujc25
approved these changes
Sep 27, 2023
prkalle
force-pushed
the
add/get_ucp_kubeconfig
branch
from
7613c76
to
33fc60b
Compare
vuil
approved these changes
Sep 28, 2023
| } | ||
|
|
||
| // AuthInfo contains information that describes identity information. This is use to tell the kubernetes cluster who you are. | ||
| type AuthInfo struct { |
There was a problem hiding this comment.
We can go with this for now, but I would like to explore whether we can process the yaml in a more generic way so we don't have to copy/maintain all this information as a followup.
- Add API to get the kubeconfig for arbitrary UCP resource given the UCP context Signed-off-by: Prem Kumar Kalle <[email protected]>
prkalle
force-pushed
the
add/get_ucp_kubeconfig
branch
from
33fc60b
to
b3a6f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds API to get the kubeconfig for an arbitrary UCP resource given the UCP context
Summary:
ucp.GetKubeconfigForContext()would construct the kubeconfig for any arbitrary UCP resource of given UCP context. It reads the kubeconfig referred by the UCP context and then updates the kubeconfig's cluster.server url to point to the requested arbitrary resource.UCP.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Unit tests and CI passed
Release note
Additional information
Special notes for your reviewer