Add Config v0.90.0 API tests (#98)

vmware-tanzu · Oct 3, 2023 · 56fc188 · 56fc188
1 parent 1da8552
commit 56fc188
Show file tree

Hide file tree

Showing 56 changed files with 6,547 additions and 2,158 deletions.
diff --git a/Makefile b/Makefile
@@ -138,6 +138,7 @@ build-compatibility-test-plugins: ## Builds all runtime compatibility test plugi
 	cd ./test/compatibility/testplugins/runtime-test-plugin-v0_11_6 && ${GO} mod tidy && GOOS=$(OS) GOARCH=$(ARCH) ${GO} build -o ../bin
 	cd ./test/compatibility/testplugins/runtime-test-plugin-v0_25_4 && ${GO} mod tidy && GOOS=$(OS) GOARCH=$(ARCH) ${GO} build -o ../bin
 	cd ./test/compatibility/testplugins/runtime-test-plugin-v0_28_0 && ${GO} mod tidy && GOOS=$(OS) GOARCH=$(ARCH) ${GO} build -o ../bin
+	cd ./test/compatibility/testplugins/runtime-test-plugin-v0_90 && ${GO} mod tidy && GOOS=$(OS) GOARCH=$(ARCH) ${GO} build -o ../bin
 	cd ./test/compatibility/testplugins/runtime-test-plugin-latest && ${GO} mod tidy && GOOS=$(OS) GOARCH=$(ARCH) ${GO} build -o ../bin
 
 # The below command runs the compatibility tests using ginkgo and filter the logs as per regex and exit code with '0' representing success and non-zero values indicating test failures

diff --git a/test/compatibility/core/api_constants.go b/test/compatibility/core/api_constants.go
@@ -96,6 +96,7 @@ const (
 	Version0116   RuntimeVersion = "v0.11.6"
 	Version0254   RuntimeVersion = "v0.25.4"
 	Version0280   RuntimeVersion = "v0.28.0"
+	Version090    RuntimeVersion = "v0.90.0"
 	VersionLatest RuntimeVersion = "latest"
 )
 
@@ -104,6 +105,7 @@ var SupportedRuntimeVersions = []RuntimeVersion{
 	Version0116,
 	Version0254,
 	Version0280,
+	Version090,
 	VersionLatest,
 }
 

diff --git a/test/compatibility/core/helpers.go b/test/compatibility/core/helpers.go
@@ -20,6 +20,7 @@ const (
 	pluginV0116  = "runtime-test-plugin-v0_11_6"
 	pluginV0254  = "runtime-test-plugin-v0_25_4"
 	pluginV0280  = "runtime-test-plugin-v0_28_0"
+	pluginV090   = "runtime-test-plugin-v0_90"
 	pluginLatest = "runtime-test-plugin-latest"
 )
 
@@ -52,6 +53,8 @@ func makeRuntimeTestPluginCommand(version RuntimeVersion) string {
 		return fmt.Sprintf("%v/%v test", pluginRoot, pluginV0254)
 	case Version0280:
 		return fmt.Sprintf("%v/%v test", pluginRoot, pluginV0280)
+	case Version090:
+		return fmt.Sprintf("%v/%v test", pluginRoot, pluginV090)
 	case VersionLatest:
 		return fmt.Sprintf("%v/%v test", pluginRoot, pluginLatest)
 	default:

diff --git a/test/compatibility/core/helpers_test.go b/test/compatibility/core/helpers_test.go
@@ -29,6 +29,19 @@ func TestConstructTestPluginCmd(t *testing.T) {
 			pluginCmd: pluginLatest,
 			err:       "",
 		},
+		{
+			version: Version090,
+			apis: []*API{
+				{
+					Name:      SetContextAPI,
+					Version:   Version090,
+					Arguments: map[APIArgumentType]interface{}{},
+					Output:    nil,
+				},
+			},
+			pluginCmd: pluginV090,
+			err:       "",
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/test/compatibility/core/parsers_test.go b/test/compatibility/core/parsers_test.go
@@ -15,7 +15,39 @@ func TestParseRuntimeAPIsFromFile(t *testing.T) {
 		apiYaml      string
 		expectedAPIs []API
 	}{
-
+		{
+			`- name: SetContext
+  version: latest
+  arguments:
+    context: |
+        name: context-one
+        target: kubernetes
+        globalOpts:
+          endpoint: test-endpoint
+    setCurrent: false
+  output:
+    result: success
+    content: ""
+`,
+			[]API{
+				{
+					Name:    SetContextAPI,
+					Version: Version090,
+					Arguments: map[APIArgumentType]interface{}{
+						Context: `name: context-one
+target: kubernetes
+globalOpts:
+  endpoint: test-endpoint
+`,
+						SetCurrent: false,
+					},
+					Output: &Output{
+						Result:  Success,
+						Content: "",
+					},
+				},
+			},
+		},
 		{
 			`- name: SetContext
   version: latest

diff --git a/test/compatibility/core/validators_test.go b/test/compatibility/core/validators_test.go
@@ -16,6 +16,13 @@ func TestValidRuntimeVersion(t *testing.T) {
 	assert.Equal(t, true, actual)
 }
 
+func TestValidRuntimeVersionV090(t *testing.T) {
+	version090 := &RuntimeAPIVersion{RuntimeVersion: "v0.90.0"}
+	actual, err := version090.Validate()
+	assert.Nil(t, err)
+	assert.Equal(t, true, actual)
+}
+
 func TestInvalidRuntimeVersion(t *testing.T) {
 	version101 := &RuntimeAPIVersion{RuntimeVersion: "v1.0.1"}
 	actual, err := version101.Validate()

diff --git a/test/compatibility/docs/cross-version-api-compatibility-framework.md b/test/compatibility/docs/cross-version-api-compatibility-framework.md
@@ -56,6 +56,7 @@ const (
    Version0116 RuntimeVersion = "v0.11.6"
    Version0254                = "v0.25.4"
    Version0280                = "v0.28.0"
+   Version090                = "v0.90.0"
    VersionLatest              = "latest"
 )
 

diff --git a/test/compatibility/docs/cross-version-api-compatibility.md b/test/compatibility/docs/cross-version-api-compatibility.md
@@ -197,6 +197,7 @@ const (
   Version0110 RuntimeVersion = "v0.11.0"
   Version0250 RuntimeVersion = "v0.25.0"
   Version0280 RuntimeVersion = "v0.28.0"
+  Version090 RuntimeVersion = "v0.90.0"
   VersionLatest RuntimeVersion = "latest"
 )
 

diff --git a/test/compatibility/framework/clidiscoverysources/cli_discoverysources_commands_test.go b/test/compatibility/framework/clidiscoverysources/cli_discoverysources_commands_test.go
@@ -25,6 +25,35 @@ func TestNewSetCLIDiscoverySourceCommand(t *testing.T) {
 		cmd        *core.Command
 		err        string
 	}{
+		{
+			&SetCLIDiscoverySourceInputOptions{
+				RuntimeAPIVersion: &core.RuntimeAPIVersion{
+					RuntimeVersion: core.Version090,
+				},
+				PluginDiscoveryOpts: &types.PluginDiscoveryOpts{
+					OCI: &types.OCIDiscoveryOpts{
+						Name:  CompatibilityTestsSourceName,
+						Image: CompatibilityTestsSourceImage,
+					},
+				},
+			}, nil,
+			&core.Command{
+				APIs: []*core.API{
+					{
+						Name:    core.SetCLIDiscoverySourceAPI,
+						Version: core.Version090,
+						Arguments: map[core.APIArgumentType]interface{}{
+							core.DiscoverySource: source,
+						},
+						Output: &core.Output{
+							ValidationStrategy: "",
+							Result:             core.Success,
+							Content:            "",
+						},
+					},
+				},
+			}, "",
+		},
 		{
 			&SetCLIDiscoverySourceInputOptions{
 				RuntimeAPIVersion: &core.RuntimeAPIVersion{
@@ -73,6 +102,40 @@ func TestNewGetCLIDiscoverySourceCommand(t *testing.T) {
 		cmd        *core.Command
 		err        string
 	}{
+		{
+			&GetCLIDiscoverySourceInputOptions{
+				RuntimeAPIVersion: &core.RuntimeAPIVersion{
+					RuntimeVersion: core.Version090,
+				},
+				DiscoverySourceName: CompatibilityTestsSourceName,
+			}, &GetCLIDiscoverySourceOutputOptions{
+				RuntimeAPIVersion: &core.RuntimeAPIVersion{
+					RuntimeVersion: core.Version0280,
+				},
+				PluginDiscoveryOpts: &types.PluginDiscoveryOpts{
+					OCI: &types.OCIDiscoveryOpts{
+						Name:  CompatibilityTestsSourceName,
+						Image: CompatibilityTestsSourceImage,
+					},
+				},
+			},
+			&core.Command{
+				APIs: []*core.API{
+					{
+						Name:    core.GetCLIDiscoverySourceAPI,
+						Version: core.Version090,
+						Arguments: map[core.APIArgumentType]interface{}{
+							core.Name: CompatibilityTestsSourceName,
+						},
+						Output: &core.Output{
+							ValidationStrategy: "",
+							Result:             core.Success,
+							Content:            source,
+						},
+					},
+				},
+			}, "",
+		},
 		{
 			&GetCLIDiscoverySourceInputOptions{
 				RuntimeAPIVersion: &core.RuntimeAPIVersion{
@@ -150,6 +213,30 @@ func TestNewDeleteCLIDiscoverySourceCommand(t *testing.T) {
 				},
 			}, "",
 		},
+		{
+			&DeleteCLIDiscoverySourceInputOptions{
+				RuntimeAPIVersion: &core.RuntimeAPIVersion{
+					RuntimeVersion: core.Version090,
+				},
+				DiscoverySourceName: CompatibilityTestsSourceName,
+			}, nil,
+			&core.Command{
+				APIs: []*core.API{
+					{
+						Name:    core.DeleteCLIDiscoverySourceAPI,
+						Version: core.Version090,
+						Arguments: map[core.APIArgumentType]interface{}{
+							core.Name: CompatibilityTestsSourceName,
+						},
+						Output: &core.Output{
+							ValidationStrategy: "",
+							Result:             core.Success,
+							Content:            "",
+						},
+					},
+				},
+			}, "",
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/test/compatibility/framework/clidiscoverysources/cli_discoverysources_helpers.go b/test/compatibility/framework/clidiscoverysources/cli_discoverysources_helpers.go
@@ -133,7 +133,7 @@ func DefaultCLIDiscoverySourcePerVersion(version core.RuntimeVersion) *CfgCLIDis
 			WithOCIDiscoveryOpts(oci),
 			WithContextType(types.CtxTypeTMC),
 		)
-	case core.VersionLatest, core.Version0280:
+	case core.VersionLatest, core.Version090, core.Version0280:
 		return NewCfgCLIDiscoverySourcesArgs(
 			WithOCIDiscoveryOpts(oci),
 		)

diff --git a/test/compatibility/framework/clidiscoverysources/cli_discoverysources_validators.go b/test/compatibility/framework/clidiscoverysources/cli_discoverysources_validators.go
@@ -20,7 +20,7 @@ func (opts *SetCLIDiscoverySourceInputOptions) Validate() (bool, error) {
 	}
 
 	switch opts.RuntimeVersion {
-	case core.VersionLatest, core.Version0280, core.Version0116:
+	case core.VersionLatest, core.Version090, core.Version0280, core.Version0116:
 		err = opts.PluginDiscoveryOpts.ValidPluginDiscovery()
 		if err != nil {
 			return false, err
@@ -65,7 +65,7 @@ func (opts *GetCLIDiscoverySourceOutputOptions) Validate() (bool, error) {
 	}
 
 	switch opts.RuntimeVersion {
-	case core.VersionLatest, core.Version0280, core.Version0116:
+	case core.VersionLatest, core.Version090, core.Version0280, core.Version0116:
 		err = opts.PluginDiscoveryOpts.ValidPluginDiscovery()
 		if err != nil {
 			return false, err