This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
Refactor loadbalancer #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making the load_balancer module more flexible by: * allowing to have multiple globe lbs * making tcp router optional * using count straight forward this isn't introducing and changes for existing objects, hence this is backwards compatible
`global` and `global_lb`are bools
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is related to #134
This PR is making the load_balancer module more flexible by:
Variables
url_map_name,http_proxy_name,https_proxy_name,http_forwarding_rule_nameandhttps_forwarding_rule_namewere introduced to keep it backwards compatible.Therefore all existing objects and names are kept, hence no update to existing deployments is required!
if merged, I would make consecutive PRs for adding an optional LB for service mesh (service mesh branch) and refactor isolation segment module to also use the load_balancer module (isoseg branch).