Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Orb of Deception for patch 1.6 and below #2190

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

codestothestars
Copy link
Contributor

@codestothestars codestothestars commented Sep 4, 2023

🍰 Pullrequest

Before patch 1.7, Orb of Deception was applied as a Dummy aura instead of a Transform aura. Otherwise the spell works the same, so we can simply reuse the existing Transform aura handling.

Proof

  • Spell.dbc

Issues

  • Orb of Deception has no effect on patch 1.6 and below. It applies the aura but the player model remains the same.

How2Test

  • .additem 1973
  • Equip Orb of Deception
  • Use orb once it's off cooldown.

Todo / Checklist

  • None

Before patch 1.7, Orb of Deception was applied as a Dummy aura instead
of a Transform aura. Otherwise the spell is nearly identical, so we
simply reuse the existing Transform aura handling.
@ratkosrb ratkosrb merged commit deb66bd into vmangos:development Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants