Correct threat for more spells. #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratkosrb
reviewed
Sep 20, 2023
|
|
||
| -- Remove Blessing of Wisdom | ||
| -- It had 0 threat value and should not exist in spell_threat | ||
| DELETE FROM `spell_threat` WHERE `entry`=19742; |
There was a problem hiding this comment.
World of Warcraft Client Patch 1.9.0 (2006-01-03)
- Blessing of Wisdom - Mana regeneration over time will no longer
generate threat.
Have you tested if it still generates threat pre 1.9 with this deletion? We should not impose the 1.12 state on previous patches.
There was a problem hiding this comment.
All I did was remove the 0 threat from entry 19742 which shouldn't have been there in the first place since it defaults to 0 threat if spell doesn't exist in spell_threat. With this PR and without this PR Blessing of Wisdom generates 0 threat when cast.
The patch note you mention is not currently implemented in vmangos, mp5 from Blessing of Wisdom is currently not able to cause threat in 1.8.4 or below. I tested this with no mana with Blessing of Wisdom applied to 100% mana and no threat was generated, even without this PR.
Benjaminmnoer
pushed a commit
to Benjaminmnoer/vmangoscore
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR corrects threat to spells that I previously missed.
Proof
/run local _,_,_,_,t=UnitDetailedThreatSituation("player","target") if t then DEFAULT_CHAT_FRAME:AddMessage(t) else DEFAULT_CHAT_FRAME:AddMessage("No threat") endCurrently this warning shows up while server is loading:
However all the spells in that list do correct threat in game.
Issues
How2Test
Todo / Checklist