Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added A Flow to Use Standard or Custom Rationale #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sacastrillon
Copy link

@sacastrillon sacastrillon commented Aug 15, 2021

Summary
This refactor allows users to use Easy Permissions Rationale (standard rationale) or create a custom rationale to be used in Easy Permissions flow, according to Android Guidelines to ask for Android Permissions.
Standard Rationale: It's a very basic AlertDialog (already implemented on the library).
Custom Rationale: It's a Lambda function where you can place a custom dialog of your preference.

Motivation
This new flow was motivated by the lack of use of custom rational dialogs with the Easy Permission library. The library is powerful and helps a lot since you don't need to handle asking for Android permission on your own, but it lacks a way to use custom Rational Dialogs created following app UI guidelines. So, I’ve proposed a method that allows Easy Permissions users to decide which path to take: Standard Rationale or Custom Rationale.

… implemented in library) and custom rationale.
@sacastrillon sacastrillon marked this pull request as ready for review August 22, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant