Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "online inference" with "online serving" #11923

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Jan 10, 2025

This PR replaces all references to online inference with online serving to consolidate the terminology in the docs. As discussed in #sig-docs on Slack.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Jan 10, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 10, 2025 10:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 10, 2025
@DarkLight1337 DarkLight1337 merged commit d85c47d into vllm-project:main Jan 10, 2025
63 of 72 checks passed
@hmellor hmellor deleted the consolidate-terminology branch January 10, 2025 12:17
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
hmellor added a commit to hmellor/vllm that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants