Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VLM] Enable tokenized inputs for merged multi-modal processor #11900

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[VLM] Enable tokenized inputs for merged multi-modal processor #11900

merged 2 commits into from
Jan 10, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jan 9, 2025 •
edited by github-actions bot
Loading

By overriding HF's prompt replacement logic with our own, token IDs can now be passed to the merged multi-modal processor.

I have updated #10114 to cover this at a high level.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 9, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py January 9, 2025 14:42
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner January 9, 2025 14:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

This was referenced Jan 9, 2025
Open
Open
@DarkLight1337
format
b32e488 
Signed-off-by: DarkLight1337 <[email protected]>
Isotr0py
Isotr0py approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vllm/model_executor/models/blip2.py Show resolved Hide resolved
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 9, 2025 15:34
@DarkLight1337 DarkLight1337 merged commit b844b99 into vllm-project:main Jan 10, 2025
55 checks passed
@DarkLight1337 DarkLight1337 deleted the mm-token-inputs branch January 10, 2025 03:27
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
@DarkLight1337 @frreiss
[VLM] Enable tokenized inputs for merged multi-modal processor (vllm-…
6d99f1e 
…project#11900)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
@DarkLight1337 @frreiss
[VLM] Enable tokenized inputs for merged multi-modal processor (vllm-…
d4284f4 
…project#11900)

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py