Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] explain how to add interleaving sliding window support #11771

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

youkaichao
Copy link
Member

to avoid the case of #11583 happening again.

Copy link

github-actions bot commented Jan 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 6, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Jan 6, 2025

Any chance you can review and merge #11755 first since that PR will move this page?

Copy link

mergify bot commented Jan 6, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @youkaichao.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 6, 2025
Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

@DarkLight1337 done

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@DarkLight1337
Copy link
Member

Docs look good, let's force-merge this.

@youkaichao youkaichao merged commit 4ca5d40 into vllm-project:main Jan 6, 2025
12 of 14 checks passed
@youkaichao youkaichao deleted the doc_interleaving branch January 6, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants