-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[distributed] remove pynccl's redundant stream #11744
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the great work!
also cc @tlrmchlsmth |
Head branch was pushed to by a user without write access
merge as buildkite/fastcheck/pr/entrypoints-test succeeds. |
This (and to an extent subsequent #11749) adds a significant performance regression on ROCm: |
* Revert "[distributed] remove pynccl's redundant change_state (vllm-project#11749)" This reverts commit 9e764e7. * Revert "[distributed] remove pynccl's redundant stream (vllm-project#11744)" This reverts commit 635b897.
@gshtras this is very surprising, I thought this PR changes nothing. Upon reflection, it seems it might be related with Can you help measure the cost of |
I've streamlined the PyNcclCommunicator codebase by removing redundant stream initializations and assignments.