Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel][Triton][AMD] Change default block size for triton_scaled_mm to 128 for 3-5x speedup #11698

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rasmith
Copy link
Contributor

@rasmith rasmith commented Jan 3, 2025

Changed default block-size for triton_scaled_mm to 128x128x128 from 32x32x32 for better performance. This results in roughly 3-5x speedup.

python benchmarks/benchmark_latency.py --dtype bfloat16 --enable-chunked-prefill False --load-format dummy --batch-size 64 --num-iters-warmup 2 --num-iters 5 --input-len 2048 --output-len 128 --model /models/Phi-3-medium-128k-instruct-quantized.w8a8/

Before:

Avg latency: 14.48 seconds

After:

Avg latency: 5.52 seconds

python benchmarks/benchmark_throughput.py --dtype bfloat16 --enable-chunked-prefill False --load-format dummy --input-len 2048 --output-len 128 --model /models/Phi-3-medium-128k-instruct-quantized.w8a8/

Before:

Throughput: 10269.32 tok/s

After:

Throughput: 31150.8 tokens/s

Copy link

github-actions bot commented Jan 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin
Copy link
Member

mgoin commented Jan 3, 2025

This is an impressive improvement! Could you also show comparisons for equal input len/output len workloads, preferably with low batchsize? This could regress the TPOT for small decode batches.

It seems there is no tuning for this kernel at the moment, so maybe this could benefit from a simple heuristic for the extreme problem sizes or a few @triton.autotune configs for the blocksizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants