Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][V1] Extend beyond image modality and support mixed-modality inference with Llava-OneVision #11685

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Jan 2, 2025

Goal of this PR:

  • Extends V1 support for multimodal models beyond image modality.
  • Infrastructure support non-interleaving mixed-modality inference (e.g, <image><image><video>What are described in these items?).
  • Adds V1 support for Llava-OneVision

Copy link

github-actions bot commented Jan 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Roger Wang <[email protected]>
vllm/model_executor/models/llava_onevision.py Show resolved Hide resolved
vllm/multimodal/utils.py Show resolved Hide resolved
vllm/v1/request.py Outdated Show resolved Hide resolved
ywang96 and others added 5 commits January 3, 2025 08:40
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
ywang96 and others added 5 commits January 3, 2025 19:17
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants