Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy worker #11675

Closed
wants to merge 3 commits into from
Closed

Mypy worker #11675

wants to merge 3 commits into from

Conversation

CloseChoice
Copy link
Contributor

@CloseChoice CloseChoice commented Jan 1, 2025

supports #3680

This PR passes:

mypy vllm/worker/*.py --follow-imports=skip --config-file pyproject.toml

Copy link

github-actions bot commented Jan 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Tobias Pitters <[email protected]>
Signed-off-by: Tobias Pitters <[email protected]>
@CloseChoice
Copy link
Contributor Author

This seems to be already implemented.

@CloseChoice CloseChoice closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant