Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] [7/N] API Server: Multiprocessing Detokenizer [ DO NOT MERGE ] #11636

Closed

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 30, 2024

NOTES:

  • Adding a 3rd process hurts performance
  • Current main API server is within 3% of the LLM performance already
  • Performance Benchmarks

So, we will abandon the 3 process architecure and go forward with the 2 process architecture

SUMMARY:

PERFORMANCE:

Server

  • Launch:
vllm serve $MODEL --no-enable-prefix-caching --gpu-memory-utilization 0.98 --max-num-batched-tokens 8192 --disable-log-requests
  • Benchmark:
python3 benchmark_serving.py --model $MODEL --dataset-name sonnet --dataset-path sonnet.txt --sonnet-input-len 250 --sonnet-output-len 200
  • Result:
  • main: 55.99 requests/sec
  • pr: 54.05 requests/sec

AsyncLLM

python3 benchmarks/benchmark_throughput.py --model $MODEL --input-len 230 --output-len 200 --no-enable-prefix-caching --gpu-memory-utilization 0.98 --max-num-batched-tokens 8192 --async-engine

>> Throughput: 55.10 requests/s
  • main
python3 benchmarks/benchmark_throughput.py --model $MODEL --input-len 230 --output-len 200 --no-enable-prefix-caching --gpu-memory-utilization 0.98 --max-num-batched-tokens 8192 --async-engine

>> Throughput: 55.26 requests/s

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic changed the title [V1] [7/N] API Server: Multiprocessing Detokenizer [V1] [7/N] API Server: Multiprocessing Detokenizer [ DO NOT MERGE ] Dec 31, 2024
@robertgshaw2-neuralmagic
Copy link
Collaborator Author

Closing as the implementation did not lead to performance gains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant