Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Validate and concatenate image embeddings in MiniCPMVBaseModel #11631

Merged

Conversation

whyiug
Copy link
Contributor

@whyiug whyiug commented Dec 30, 2024

When performing batch embedding on different images, list needs to be converted.
FIX #11630

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

(Note to others: we don't need to preserve the batch dimension since merge_multimodal_embeddings doesn't really care about that anyway)

@DarkLight1337 DarkLight1337 changed the title [Model] Validate and concatenate image embeddings in MiniCPMVBaseModel [Bugfix] Validate and concatenate image embeddings in MiniCPMVBaseModel Dec 30, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 30, 2024 16:16
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 30, 2024
@DarkLight1337 DarkLight1337 merged commit 36e7670 into vllm-project:main Dec 30, 2024
68 checks passed
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
2 participants