[VLM] Abstract out multi-modal data parsing in merged processor #11620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
This was referenced Dec 30, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
changed the title
DarkLight1337
changed the title
Isotr0py
reviewed
Dec 30, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
github-actions
bot
added
the
ready
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…-project#11620) Signed-off-by: DarkLight1337 <[email protected]>
This was referenced Dec 31, 2024
xcnick
pushed a commit
to xcnick/vllm
that referenced
this pull request
Dec 31, 2024
…-project#11620) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: xcnick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts out the logic of parsing input multi-modal data and converting them into HF processor inputs.
This corresponds to the plugin-based abstraction we have in the original code. Once we migrate all models to the merged multi-modal processor, we will deprecate multi-modal plugins and instead ask developers to modify the data parser to support additional modalities for a model (by overriding
BaseMultiModalProcessor._get_data_parser).