Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix parameter names and process_after_weight_loading for W4A16 MoE Group Act Order #11528

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Dec 26, 2024

Summary

  • Fix parameter names to ensure proper weight loading
  • Fix process_after_weight_loading if running group act order
  • Don't shard w2 weight_scales when running actorder for tp>1

Testing

  • Tested with tp>=1 with mixtral and deepseek WNA16

Next Steps:

  • GPTQMarlin MoE method likely needs to be updated on its sharding condition for actorder

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@eldarkurtic
Copy link

I can confirm it works with tp>1

@dsikka dsikka marked this pull request as ready for review December 27, 2024 02:17
@dsikka
Copy link
Contributor Author

dsikka commented Dec 27, 2024

@mgoin
@robertgshaw2-neuralmagic
@ElizaWszola

Copy link

mergify bot commented Jan 7, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @dsikka.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@dsikka dsikka requested review from ElizaWszola and mgoin January 16, 2025 21:35
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 16, 2025
# Will transpose the loaded weight along the
# intermediate and hidden dim sizes. Will
# shard for TP along the transposed dims
intermediate_full = extra_weight_attrs.pop("intermediate_full")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe rename intermediate_size -> intermediate_size_per_partition and intermediate_full -> intermediate_size?
This would make the names consistent with other quant configs, e.g. vllm/model_executor/layers/quantization/gptq.py

@dsikka dsikka force-pushed the fix_w4a16moe_actorder branch from a68004b to c2bce52 Compare January 17, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants