Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amd-installation.md #11470

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

johnnynunez
Copy link

rocm 6.3

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 24, 2024
@DarkLight1337
Copy link
Member

We still use ROCm 6.2 in the Dockerfile.rocm, could you elaborate on why the docs need to be changed?

@johnnynunez
Copy link
Author

johnnynunez commented Dec 24, 2024

We still use ROCm 6.2 in the Dockerfile.rocm, could you elaborate on why the docs need to be changed?

I'm updating (still not docker). It is for new hardware device and improve a lot in flash attention
https://www.amd.com/es/products/accelerators/instinct/mi300/mi325x.html

flash attention performance:
https://community.amd.com/t5/ai/unlocking-new-horizons-in-ai-and-hpc-with-the-release-of-amd/ba-p/726434
FlashAttention-2 optimized for ROCm 6.3 is talking up to 3x speed-ups and other benefits.

Pytorch:
6.3.0 ROCM is on CI nightly from this week

@mergify mergify bot added the ci/build label Dec 24, 2024
@johnnynunez
Copy link
Author

rocm6.3.1 and pytorch 2.5 is coming also

Copy link

mergify bot commented Dec 27, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @johnnynunez.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 27, 2024
@DarkLight1337
Copy link
Member

Is this superseded by #11777?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation needs-rebase rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants