Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Automatic conversion of classification and reward models #11469

Merged
merged 7 commits into from
Dec 24, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 24, 2024

This is the last PR to finish off #10674.

CLOSE #10674
FIX #11459

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 24, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member Author

cc @maxdebayser

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 24, 2024 17:05
@DarkLight1337 DarkLight1337 merged commit 3f3e92e into vllm-project:main Dec 24, 2024
56 checks passed
@DarkLight1337 DarkLight1337 deleted the pooling-adapters branch December 25, 2024 02:17
@umie0128
Copy link

@DarkLight1337 hi 我看到vllm0.6.4/0.6.5 更新说有速度上的提升 但是我对比了0.6.2 跑qwen2.5-7B 感觉速度没有变化。请问是为啥呢

@DarkLight1337
Copy link
Member Author

@DarkLight1337 hi 我看到vllm0.6.4/0.6.5 更新说有速度上的提升 但是我对比了0.6.2 跑qwen2.5-7B 感觉速度没有变化。请问是为啥呢

Hi, this PR is about pooling models, not text generation models. Can you open a new issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
3 participants