Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploying_with_k8s.md with AMD ROCm GPU example #11465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexHe99
Copy link
Contributor

@AlexHe99 AlexHe99 commented Dec 24, 2024

Add the example of using AMD ROCm GPU

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 24, 2024
Add the example of using AMD ROCm GPU

Signed-off-by: Alex He <[email protected]>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 25, 2024

To better organize things, can we make each step a section and have separate sub-sections for NVIDIA vs AMD GPUs?

- name: shm
mountPath: /dev/shm
```
The full example is at https://github.com/ROCm/k8s-device-plugin/tree/master/example/vllm-serve.
Copy link
Member

@DarkLight1337 DarkLight1337 Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The full example is at https://github.com/ROCm/k8s-device-plugin/tree/master/example/vllm-serve.
The full example is at <https://github.com/ROCm/k8s-device-plugin/tree/master/example/vllm-serve>.

Also we should make this an actual link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants