Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cd][release] fix race conditions #11407

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Dec 22, 2024

we have two release pipelines, and this can cause race conditions.

let's only generate index for cuda 12 wheels.

to deal with cuda 11.8 wheels, we need to have a separate index url. left as a TODO right now.

Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 22, 2024
@youkaichao youkaichao requested a review from ywang96 December 22, 2024 08:13
@youkaichao youkaichao merged commit 72d9c31 into vllm-project:main Dec 22, 2024
14 of 16 checks passed
@youkaichao youkaichao deleted the fix_cu118 branch December 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants