Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Adding API Key to the benchmark #11384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bjb19
Copy link

@bjb19 bjb19 commented Dec 20, 2024

This adds an option to include an API Key to the benchmark command to access a secured VLLM Server

Signed-off-by: Benjamin Bischoff <[email protected]>
Signed-off-by: Benjamin Bischoff <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo
Copy link
Collaborator

instead of a new argument, i believe you can just run the command with OPENAI_API_KEY env var? anything missing from that workflow?

@bjb19
Copy link
Author

bjb19 commented Dec 20, 2024

@simon-mo That is true it does cover this. I had to dig through the source code to maybe updating the docs is also a reasonable solution. I thought this might be better by providing a cli param for providing visibility, extensibility in the future, and for switching out for different keys easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants