Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Make AsyncLLMEngine v1-v0 opaque #11383

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Dec 20, 2024

Right now, users of the AsyncLLMEngine will have to modify their code to use V1 even if VLLM_USE_V1=1 is used.

We should have the V1/V0 behaviour changed by VLLM_USE_V1 sorely as much as possible.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 20, 2024
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx rickyyx force-pushed the ricky/v1-async-engine branch from 0ab6855 to 2604dbc Compare December 20, 2024 18:49
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comaniac comaniac added ready ONLY add when PR is ready to merge/full CI is needed and removed frontend labels Dec 20, 2024
@mergify mergify bot added the frontend label Dec 20, 2024
@rickyyx
Copy link
Contributor Author

rickyyx commented Dec 20, 2024

Test failures look unrelated on AMD.

@DarkLight1337 DarkLight1337 merged commit 584f0ae into vllm-project:main Dec 21, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants