-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Don't log OpenAI field aliases as ignored #11378
[Bugfix] Don't log OpenAI field aliases as ignored #11378
Conversation
Signed-off-by: mgoin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Signed-off-by: mgoin <[email protected]> Signed-off-by: lucast2021 <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
Signed-off-by: mgoin <[email protected]>
FIX #11363
This issue was found because we use an alias for
schema
inJsonSchemaResponseFormat
due to conflicts with pydantic:Our logging for unused fields in requests was not taking into account aliases, so we were incorrectly reporting that fields were being ignored