Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Build/CI] Fix sparse CUTLASS compilation on CUDA [12.0, 12.2) #11311

Merged

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented Dec 18, 2024

We were checking against CUDA 12.0 when we should have been checking for 12.2

https://github.com/NVIDIA/cutlass/blob/e1cd8c7866dd6de02b66a89879795e7d7301aacc/examples/62_hopper_sparse_gemm/62_hopper_sparse_gemm.cu#L553-L559

I also plumbed up a cutlass_sparse_scaled_mm_supported function so we can fail more gracefully if the kernel is not supported.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 18, 2024
@tlrmchlsmth tlrmchlsmth force-pushed the fix_sparse_cutlass_compilation branch from 4b8652d to fbc974d Compare December 18, 2024 22:55
@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 18, 2024
Signed-off-by: Tyler Michael Smith <[email protected]>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with clear messages and comments, thanks

csrc/sparse/cutlass/sparse_compressor_c3x.cu Show resolved Hide resolved
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) December 19, 2024 00:32
@tlrmchlsmth tlrmchlsmth merged commit 5a9da2e into vllm-project:main Dec 19, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants