-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1] Simplify prefix caching logic by removing num_evictable_computed_blocks
#11310
Conversation
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch. I guess it was useful but became useless after some iterations of refactoring...
…d_blocks` (vllm-project#11310) Signed-off-by: Bowen Wang <[email protected]>
The
evictable_computed_blocks
are removed fromself.free_block_queue
duringself._touch(computed_blocks)
, so we do not need to treat them specially inallocate_slots
.The
num_evictable_computed_blocks
is always zero (I've checked here 667af1b) becauseself._touch
also increases the reference count by one.The below command has no diff in performance.