Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] IBM Granite 3.1 #11307

Merged

Conversation

tjohnson31415
Copy link
Contributor

@tjohnson31415 tjohnson31415 commented Dec 18, 2024

IBM just released new Granite 3.1 models (Press Release; HF Hub).

Tool calling with the new version is different becuase it uses a <tool_call> html-style string to mark the start of a tool call response instead of the <|tool_call|> token. The default chat template from HF Hub passes the unit tests, so I did not add a new chat template jinja file to the examples directory (but the current tool_chat_template_granite.jinja file should not be used with the 3.1 models).

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Dec 18, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see no modeling changes. LGTM after removing print and with green build

docs/source/usage/tool_calling.md Show resolved Hide resolved
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 18, 2024
@tjohnson31415 tjohnson31415 force-pushed the granite-3-1-tool-calling branch from 16c09d5 to 52c8e69 Compare December 18, 2024 23:27
@DarkLight1337 DarkLight1337 merged commit 17ca964 into vllm-project:main Dec 19, 2024
52 checks passed
@tjohnson31415 tjohnson31415 deleted the granite-3-1-tool-calling branch December 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants