Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] API Server Performance #11237

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 16, 2024

SUMMARY:

  • Improve API server performance by switching from AsyncStream to asyncio.Event as concurrency method between output_handler and generate() in AsyncLLM and implementing dynamic chunked streaming
  • Performance looks good, but getting too bumpy ITL (we can still fall too far behind in the API server)

TODO (this PR):

  • Add 3rd process to isolate detokenizer and the streaming
  • Support ChatCompletions
  • Support cancellation
  • Better correctness testings (need to hack lm-eval to support streaming)
  • Another round of performance benchmarks

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 16, 2024
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic changed the title workign e2e [V1] API Server Performance Dec 16, 2024
@mergify mergify bot removed the needs-rebase label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant