Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/build] Fix entrypoints test and pin outlines version #11088

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Dec 11, 2024

#10576 ran CI and passed with outlines==0.1.8 but outline 0.1.9 released and had a change to use outlines-core instead of outlines for one of the import paths: https://github.com/dottxt-ai/outlines/pull/1311/files#diff-b29e16a237d75d6560f08ec4c09049474c96d34e4c4f544dde27002ae1f684d9L3 which broke CI since outlines version is not pinned.

This PR fixes the import path and also pins outlines==0.1.9

@khluu khluu changed the title [ci/build] Fix entrypoints [ci/build] Fix entrypoints test and pin outlines version Dec 11, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 11, 2024
@youkaichao youkaichao merged commit 9974fca into main Dec 11, 2024
26 of 30 checks passed
@youkaichao youkaichao deleted the khluu/fix_entrypoints branch December 11, 2024 09:01
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants