Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][VLM] Add V1-rearch image inference support for Qwen2-VL #10988

Closed
wants to merge 1 commit into from

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 8, 2024

Separated out from #10699

  • Placeholder ranges
  • Embedding generation refactoring
  • M-RoPE implementation
  • Fix image embedding as input test

Signed-off-by: Roger Wang <[email protected]>
Copy link

github-actions bot commented Dec 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ywang96
Copy link
Member Author

ywang96 commented Dec 10, 2024

Hello @fyabc! We're currently going through re-architecture of vLLM and I'm wondering if it's possible to add M-RoPE into the model file instead of the model runner. Do you have any suggestion?

@ywang96 ywang96 closed this by deleting the head repository Dec 14, 2024
@fyabc
Copy link
Contributor

fyabc commented Dec 23, 2024

Hi @ywang96 , sorry for late response, any update for this PR?

@ywang96
Copy link
Member Author

ywang96 commented Dec 23, 2024

Hi @ywang96 , sorry for late response, any update for this PR?

@fyabc Hello! I closed this PR by accident, but I haven't really made too much progress on Qwen2 VL (mostly I'm not sure if we can put MRoPE inside the model file instead of the model runner) If it makes things easier feel free to join slack.vllm.ai so we can discuss more offline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants