-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][Kernel]: fix illegal memory access in causal_conv1d when conv_states is None #10928
Conversation
Signed-off-by: xffxff <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Thanks for fixing the bug! it would be great if you could add a test case to test_causal_conv1d.py for running the causal_conv1d_fn kernel without an initial state |
Signed-off-by: xffxff <[email protected]>
@mzusman I've added tests for |
Thanks! LGTM @tlrmchlsmth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. LGTM, leaving the final decision to @tlrmchlsmth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
…v_states is None (vllm-project#10928) Signed-off-by: xffxff <[email protected]>
fix #10895
Issue #10895 reports an illegal memory access error on H100 GPUs when calling the
causal_conv1d_fn
function with specific input shapes and whenconv_states
is not provided. After some investigation, I found that the root cause as an attempt to assign a value to anullptr
.cc @mzusman @tlrmchlsmth