Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][Kernel]: fix illegal memory access in causal_conv1d when conv_states is None #10928

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

xffxff
Copy link
Contributor

@xffxff xffxff commented Dec 5, 2024

fix #10895

Issue #10895 reports an illegal memory access error on H100 GPUs when calling the causal_conv1d_fn function with specific input shapes and when conv_states is not provided. After some investigation, I found that the root cause as an attempt to assign a value to a nullptr.

cc @mzusman @tlrmchlsmth

Copy link

github-actions bot commented Dec 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mzusman
Copy link
Contributor

mzusman commented Dec 5, 2024

Thanks for fixing the bug! it would be great if you could add a test case to test_causal_conv1d.py for running the causal_conv1d_fn kernel without an initial state

@xffxff
Copy link
Contributor Author

xffxff commented Dec 6, 2024

it would be great if you could add a test case to test_causal_conv1d.py for running the causal_conv1d_fn kernel without an initial state

@mzusman I've added tests for causal_conv1d_fn kernel without an initial state and all the tests passed successfully in my local environment.

@mzusman
Copy link
Contributor

mzusman commented Dec 6, 2024

it would be great if you could add a test case to test_causal_conv1d.py for running the causal_conv1d_fn kernel without an initial state

@mzusman I've added tests for causal_conv1d_fn kernel without an initial state and all the tests passed successfully in my local environment.

Thanks! LGTM @tlrmchlsmth

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM, leaving the final decision to @tlrmchlsmth

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 6, 2024
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@DarkLight1337 DarkLight1337 merged commit 78029b3 into vllm-project:main Dec 7, 2024
83 of 85 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: illegal memory access in causal_conv1d_fn with input length 1026
5 participants