Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][Gaudi] Avoid torch.compile and enable lazy collectives by default for HPU lazy backend #10897

Merged

Conversation

kzawora-intel
Copy link
Contributor

@kzawora-intel kzawora-intel commented Dec 4, 2024

Similar to #10747, but applied specifically to PT HPU lazy backend. While PyTorch for Gaudi has torch.compile support, it currently needs to be enabled explicitly, and best performance is achieved with HPUGraphs instead. This patch disables torch.compile for PT lazy mode and HPUGraphs (HPU execution modes for reference: https://docs.vllm.ai/en/latest/getting_started/gaudi-installation.html#execution-modes), and leaves it on for PT eager/torch.compile mode. Additionaly, it automatically sets the flag for enabling lazy collectives required in multi-HPU inference with HPUGraphs, fixing frequently reported RuntimeError: collective nonSFG is not supported during hpu graph capturing error.

Copy link

github-actions bot commented Dec 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@kzawora-intel kzawora-intel force-pushed the private/kzawora/lazy_compile_disable branch 3 times, most recently from 0c1a4f9 to 9dc0d44 Compare December 4, 2024 12:41
@kzawora-intel kzawora-intel force-pushed the private/kzawora/lazy_compile_disable branch from 9dc0d44 to a2d7e3a Compare December 4, 2024 12:42
Signed-off-by: Konrad Zawora <[email protected]>
@kzawora-intel kzawora-intel force-pushed the private/kzawora/lazy_compile_disable branch from d391dee to a6d9c38 Compare December 4, 2024 12:47
Copy link
Contributor

@jikunshang jikunshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me cc @youkaichao to sign off before merge

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 5, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youkaichao youkaichao merged commit a430652 into vllm-project:main Dec 5, 2024
58 of 61 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants