-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build][Bugfix] Using the correct type hint #10866
Conversation
Signed-off-by: Gregory Shtrasberg <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, makes sense
Does cython not allow subscripting |
Lowercase |
I'm aware that this is not a type hint. The ability to subscript |
Apparently not for type. According to the issue tracker it is supposed to be working for collections. |
Signed-off-by: Gregory Shtrasberg <[email protected]>
Fix type hint error introduced in #10769
This becomes critical when using cython compilation
cc @DarkLight1337