Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build][Bugfix] Using the correct type hint #10866

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

gshtras
Copy link
Contributor

@gshtras gshtras commented Dec 3, 2024

Fix type hint error introduced in #10769
This becomes critical when using cython compilation
cc @DarkLight1337

Signed-off-by: Gregory Shtrasberg <[email protected]>
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, makes sense

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
@mgoin mgoin merged commit a061fe6 into vllm-project:main Dec 3, 2024
62 checks passed
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 4, 2024

Does cython not allow subscripting type? We are using Python 3.9 already so it should be supported in pure Python.

@gshtras
Copy link
Contributor Author

gshtras commented Dec 4, 2024

Does cython not allow subscripting type? We are using Python 3.9 already so it should be supported in pure Python.

Lowercase type is not a type hint, but rather a keyword and a function, for the type hint there is Type from typing.
While pure python ignores type hints in runtime, cython builds the compilable C code based on them, with strong runtime checks, and so it fails in runtime due to
TypeError: 'type' object is not subscriptable

@gshtras gshtras deleted the type_hint_fix_upstream branch December 4, 2024 16:23
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 4, 2024

Does cython not allow subscripting type? We are using Python 3.9 already so it should be supported in pure Python.

Lowercase type is not a type hint, but rather a keyword and a function, for the type hint there is Type from typing. While pure python ignores type hints in runtime, cython builds the compilable C code based on them, with strong runtime checks, and so it fails in runtime due to TypeError: 'type' object is not subscriptable

I'm aware that this is not a type hint. The ability to subscript type directly was added in Python 3.9 (PEP 585), which deprecates the use of typing.Type. Is that not the case for Cython?

@gshtras
Copy link
Contributor Author

gshtras commented Dec 4, 2024

Does cython not allow subscripting type? We are using Python 3.9 already so it should be supported in pure Python.

Lowercase type is not a type hint, but rather a keyword and a function, for the type hint there is Type from typing. While pure python ignores type hints in runtime, cython builds the compilable C code based on them, with strong runtime checks, and so it fails in runtime due to TypeError: 'type' object is not subscriptable

I'm aware that this is not a type hint. The ability to subscript type directly was added in Python 3.9 (PEP 585), which deprecates the use of typing.Type. Is that not the case for Cython?

Apparently not for type. According to the issue tracker it is supposed to be working for collections.

sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants