Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Add JambaForSequenceClassification model #10860

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

yecohn
Copy link
Contributor

@yecohn yecohn commented Dec 3, 2024

[Model] Add support for embedding model JambaClassfication](#10858)

Yehoshua Cohen added 2 commits December 3, 2024 13:34
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot mentioned this pull request Dec 3, 2024
@DarkLight1337
Copy link
Member

Thanks for adding this, do you have a HF repo that we can refer to? Don't forget to update the Supported Models page.

@yecohn yecohn changed the title Add jamba classfication [Model] Add support for embedding model JambaClassfication] Dec 3, 2024
@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 4, 2024
@yecohn yecohn changed the title [Model] Add support for embedding model JambaClassfication] [Model] Add support for embedding model JambaClassfication Dec 4, 2024
@yecohn yecohn changed the title [Model] Add support for embedding model JambaClassfication [Model] Add JambaClassfication model Dec 4, 2024
@noamgai21
Copy link

We have a test model that can be used to test the functionality of the code:
https://huggingface.co/ai21labs/Jamba-tiny-reward-dev

@DarkLight1337
Copy link
Member

We have a test model that can be used to test the functionality of the code: https://huggingface.co/ai21labs/Jamba-tiny-reward-dev

Thanks for this! I'll update the PR accordingly so that the model tests can pass.

Signed-off-by: DarkLight1337 <[email protected]>
Copy link

mergify bot commented Dec 19, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yecohn.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 19, 2024
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 19, 2024
@DarkLight1337 DarkLight1337 changed the title [Model] Add JambaClassfication model [Model] Add JambaForSequenceClassification model Dec 19, 2024
@mergify mergify bot removed the needs-rebase label Dec 19, 2024
@tomeras91
Copy link
Contributor

@DarkLight1337 - DCO is the only failing check. Can this get a force merge?

@DarkLight1337 DarkLight1337 merged commit 6c7f881 into vllm-project:main Dec 19, 2024
55 checks passed
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 24, 2024

I just realized that this model is supposed to be a reward model, not a classification model... should we rename the model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants