Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fixed parameter “n” not work when set parameter “bestof” > 1 #10854

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

o2363286
Copy link
Contributor

@o2363286 o2363286 commented Dec 3, 2024

[bugfix] fixed parameter “n” not work when set parameter “bestof” > 1

this PR fixed parameter “n” not work when set parameter “bestof” > 1. the key reason is that the class SamplingParams‘s clone() function will result in SamplingParams‘s post_init() function invoked again.

Signed-off-by: jianzheng <[email protected]>
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@o2363286 o2363286 changed the title Update sampling_params.py [bugfix] Update sampling_params.py Dec 4, 2024
@o2363286 o2363286 changed the title [bugfix] Update sampling_params.py [bugfix] fixed parameter “n” not work when set parameter “bestof” > 1 Dec 4, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao enabled auto-merge (squash) December 4, 2024 06:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2024
@youkaichao youkaichao merged commit 8db957e into vllm-project:main Dec 4, 2024
63 of 65 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants