Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Speculative Decoding] Move indices to device before filtering output #10850

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Speculative Decoding] Move indices to device before filtering output #10850

merged 1 commit into from
Dec 3, 2024

Conversation

zhengy001
Copy link
Contributor

@zhengy001 zhengy001 commented Dec 3, 2024 •
edited by github-actions bot
Loading

Avoid multiple cudaStreamSynchronize in _filter_model_output

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@zhengy001
Copy link
Contributor Author

zhengy001 commented Dec 3, 2024 •
edited
Loading

before
before

after
after

@zhengy001
Copy link
Contributor Author

@sroy745, could you please take a review?

sroy745
sroy745 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@sroy745 sroy745 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
cc: @LiuXiaoxuanPKU

@sroy745 sroy745 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
@DarkLight1337 DarkLight1337 merged commit f6084f6 into vllm-project:main Dec 3, 2024
65 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@zhengy001
[Speculative Decoding] Move indices to device before filtering output (…
25c700c 
…vllm-project#10850)

Co-authored-by: Yang Zheng(SW)(Alex) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroy745 sroy745 sroy745 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengy001 @sroy745 @DarkLight1337